[Intel-wired-lan] [PATCH net-next] igc: avoid kernel warning when changing RX ring parameters
Corinna Vinschen
vinschen at redhat.com
Thu Jan 13 16:00:21 UTC 2022
Calling ethtool changing the RX ring parameters like this:
$ ethtool -G eth0 rx 1024
triggers the "Missing unregister, handled but fix driver" warning in
xdp_rxq_info_reg().
igc_ethtool_set_ringparam() copies the igc_ring structure but neglects to
reset the xdp_rxq_info member before calling igc_setup_rx_resources().
This in turn calls xdp_rxq_info_reg() with an already registered xdp_rxq_info.
This fix initializes the xdp_rxq_info member prior to calling
igc_setup_rx_resources(), exactly like igb.
Fixes: 73f1071c1d29 ("igc: Add support for XDP_TX action")
Signed-off-by: Corinna Vinschen <vinschen at redhat.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 8cc077b712ad..93839106504d 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -671,6 +671,10 @@ igc_ethtool_set_ringparam(struct net_device *netdev,
memcpy(&temp_ring[i], adapter->rx_ring[i],
sizeof(struct igc_ring));
+ /* Clear copied XDP RX-queue info */
+ memset(&temp_ring[i].xdp_rxq, 0,
+ sizeof(temp_ring[i].xdp_rxq));
+
temp_ring[i].count = new_rx_count;
err = igc_setup_rx_resources(&temp_ring[i]);
if (err) {
--
2.27.0
More information about the Intel-wired-lan
mailing list