[Intel-wired-lan] [PATCH] iavf: Remove useless DMA-32 fallback configuration

Jankowski, Konrad0 konrad0.jankowski at intel.com
Thu Jan 20 08:03:52 UTC 2022



> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
> Sent: niedziela, 9 stycznia 2022 19:24
> To: Brandeburg, Jesse <jesse.brandeburg at intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen at intel.com>; David S. Miller <davem at davemloft.net>;
> Jakub Kicinski <kuba at kernel.org>
> Cc: linux-kernel at vger.kernel.org; kernel-janitors at vger.kernel.org;
> Christophe JAILLET <christophe.jaillet at wanadoo.fr>; Christoph Hellwig
> <hch at lst.de>; Lobakin, Alexandr <alexandr.lobakin at intel.com>; intel-wired-
> lan at lists.osuosl.org; netdev at vger.kernel.org
> Subject: [PATCH] iavf: Remove useless DMA-32 fallback configuration
> 
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
> 
> Simplify code and remove some dead code accordingly.
> 
> [1]: https://lkml.org/lkml/2021/6/7/398
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Alexander Lobakin <alexandr.lobakin at intel.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 8125b9120615..b0bd95c85480 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c

Tested-by: Konrad Jankowski <konrad0.jankowski at intel.com>


More information about the Intel-wired-lan mailing list