[Intel-wired-lan] [PATCH net v1] ice: fix IPIP and SIT TSO offload

G, GurucharanX gurucharanx.g at intel.com
Mon Feb 7 20:32:21 UTC 2022



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Jesse Brandeburg
> Sent: Saturday, January 15, 2022 5:09 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH net v1] ice: fix IPIP and SIT TSO offload
> 
> The driver was avoiding offload for IPIP (at least) frames due to parsing the
> inner header offsets incorrectly when trying to check lengths.
> 
> This length check works for VXLAN frames but fails on IPIP frames because
> skb_transport_offset points to the inner header in IPIP frames, which meant
> the subtraction of transport_header from inner_network_header returns a
> negative value (-20).
> 
> With the code before this patch, everything continued to work, but GSO was
> being used to segment, causing throughputs of 1.5Gb/s per thread.
> After this patch, throughput is more like 10Gb/s per thread for IPIP traffic.
> 
> Fixes: e94d44786693 ("ice: Implement filter sync, NDO operations and bump
> version")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> --
> Testing Hints: test IPIP tunnel and VXLAN tunnel, both should use TSO.
> ---
>  .../net/ethernet/intel/ice/ice_lan_tx_rx.h    |  1 +
>  drivers/net/ethernet/intel/ice/ice_main.c     | 25 +++++++++++++------
>  2 files changed, 18 insertions(+), 8 deletions(-)
> 

Tested-by: Gurucharan G <gurucharanx.g at intel.com> (A Contingent worker at Intel)


More information about the Intel-wired-lan mailing list