[Intel-wired-lan] [PATCH net v2] igc: igc_read_phy_reg_gpy: drop premature return

naamax.meir naamax.meir at linux.intel.com
Wed Feb 23 07:00:56 UTC 2022


On 2/16/2022 15:31, Corinna Vinschen wrote:
> igc_read_phy_reg_gpy checks the return value from igc_read_phy_reg_mdic
> and if it's not 0, returns immediately. By doing this, it leaves the HW
> semaphore in the acquired state.
>
> Drop this premature return statement, the function returns after
> releasing the semaphore immediately anyway.
>
> Fixes: 5586838fe9ce ("igc: Add code for PHY support")
> Signed-off-by: Corinna Vinschen<vinschen at redhat.com>
> Acked-by: Sasha Neftin<sasha.neftin at intel.com>
> ---
>
> v2: Add "Fixes:" tag
>
>   drivers/net/ethernet/intel/igc/igc_phy.c | 2 --
>   1 file changed, 2 deletions(-)
Tested-by: Naama Meir <naamax.meir at linux.intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20220223/0f06e9a3/attachment-0001.html>


More information about the Intel-wired-lan mailing list