[Intel-wired-lan] [PATCH net-next 1/6] ice: add newline to dev_dbg in ice_vf_fdir_dump_info

[Paul Menzel]

Dear Jacob,


Am 12.04.22 um 01:29 schrieb Jacob Keller:
> The debug print in ice_vf_fdir_dump_info don't end in newlines. This can

Singular? does not

> look confusing when reading the kernel log, as the next print will
> immediately continue on the same line.
> 
> Fix this.
> 

Add a Fixes tag?

Maybe also add *forgotten* to the commit message summary:

Add forgotten newline …

> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> index 8e38ee2faf58..dbc1965c0609 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> @@ -1349,7 +1349,7 @@ static void ice_vf_fdir_dump_info(struct ice_vf *vf)
>   
>   	fd_size = rd32(hw, VSIQF_FD_SIZE(vsi_num));
>   	fd_cnt = rd32(hw, VSIQF_FD_CNT(vsi_num));
> -	dev_dbg(dev, "VF %d: space allocated: guar:0x%x, be:0x%x, space consumed: guar:0x%x, be:0x%x",
> +	dev_dbg(dev, "VF %d: space allocated: guar:0x%x, be:0x%x, space consumed: guar:0x%x, be:0x%x\n",
>   		vf->vf_id,
>   		(fd_size & VSIQF_FD_CNT_FD_GCNT_M) >> VSIQF_FD_CNT_FD_GCNT_S,
>   		(fd_size & VSIQF_FD_CNT_FD_BCNT_M) >> VSIQF_FD_CNT_FD_BCNT_S,

Reviewed-by: Paul Menzel <pmenzel at molgen.mpg.de>


Kind regards,

Paul