[Intel-wired-lan] [PATCH v1 1/1] igc: Remove unused phy_type enum

[Neftin, Sasha]

On 4/13/2022 21:13, Tony Nguyen wrote:
> 
> On 4/12/2022 10:33 PM, Sasha Neftin wrote:
> 
> <snip>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c 
>> b/drivers/net/ethernet/intel/igc/igc_phy.c
>> index 6961f65d36b9..4f06e6bb68b1 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
>> @@ -150,13 +150,9 @@ s32 igc_check_downshift(struct igc_hw *hw)
>>       struct igc_phy_info *phy = &hw->phy;
>>       s32 ret_val;
>> -    switch (phy->type) {
>> -    case igc_phy_i225:
>> -    default:
>> -        /* speed downshift not supported */
>> -        phy->speed_downgraded = false;
>> -        ret_val = 0;
>> -    }
>> +    /* speed downshift not supported */
>> +    phy->speed_downgraded = false;
>> +    ret_val = 0;
>>       return ret_val;
> 
> ret_val isn't needed since it's always returning 0 and could possibly be 
> made a void function.
Thank you, Tony, right. I believe it is a minor logical change - it 
should be a different patch. I remember we have a few similar cases in 
igc. I plan (TODO) to fix them.
> 
> Thanks,
> 
> Tony
>