[Intel-wired-lan] [PATCH RESEND] i40e: Remove unnecessary synchronize_irq() before free_irq()

G, GurucharanX gurucharanx.g at intel.com
Tue May 24 13:48:33 UTC 2022



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Thursday, May 19, 2022 3:01 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zeal Robot <zealci at zte.com.cn>; Minghao Chi
> <chi.minghao at zte.com.cn>
> Subject: [Intel-wired-lan] [PATCH RESEND] i40e: Remove unnecessary
> synchronize_irq() before free_irq()
> 
> From: Minghao Chi <chi.minghao at zte.com.cn>
> 
> Calling synchronize_irq() right before free_irq() is quite useless. On one hand
> the IRQ can easily fire again before free_irq() is entered, on the other hand
> free_irq() itself calls synchronize_irq() internally (in a race condition free
> way), before any state associated with the IRQ is freed.
> 
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao at zte.com.cn>
> ---
> Resending due to mail issues with Intel Wired LAN
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g at intel.com> (A Contingent worker at Intel)


More information about the Intel-wired-lan mailing list