[Intel-wired-lan] [PATCH net v1] iavf: Disallow changing rx/tx-frames and rx/tx-frames-irq
Tony Nguyen
anthony.l.nguyen at intel.com
Wed Jun 8 23:11:23 UTC 2022
On 6/7/2022 4:25 PM, Jun Zhang wrote:
> Remove support for rx/tx-frames and rx/tx-frames-irq as it is
> introducing counterintuitive settings and is not stated in any
> requirement.
> Remove from supported_coalesce_params ETHTOOL_COALESCE_MAX_FRAMES
> and ETHTOOL_COALESCE_MAX_FRAMES_IRQ. As tx-frames-irq allowed
> user to change budget for iavf_clean_tx_irq, remove work_limit
> and use define for budget.
> Without this patch there would be possiblity to change rx/tx-frames
> and rx/tx-frames-irq, which for rx/tx-frames did nothing, while for
> rx/tx-frames-irq it changed rx/tx-frames and only changed budget
> for cleaning NAPI poll.
> > Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski at intel.com>
> Signed-off-by: Jun Zhang <xuejun.zhang at intel.com>
Same question/comment on this and for your other patch [1]. Please
either fix ordering or change author based on which situation is happening.
[1]
https://lore.kernel.org/intel-wired-lan/20220608170540.3463098-1-xuejun.zhang@intel.com/T/#u
More information about the Intel-wired-lan
mailing list