[Intel-wired-lan] [PATCH net v3] iavf: Do not modify queue number when removing iavf driver

Tony Nguyen anthony.l.nguyen at intel.com
Wed Jun 8 23:31:01 UTC 2022



On 6/8/2022 2:53 AM, Jedrzej Jagielski wrote:
> From: Grzegorz Szczurek <grzegorzx.szczurek at intel.com>
> 
> If VF has configured tc qdisc with number of queues less than original
> set and then the driver went in removing process, tc resources are also
> releasing. Attempt of modify real num tx/rx in this state is causing
> call trace, because kernel is trying to release uninitialized queues
> 
> Fix it by not modifying the number of queues when removing a driver

<snip>

> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -3471,6 +3471,9 @@ static int __iavf_setup_tc(struct net_device *netdev, void *type_data)
>   		}
>   	}
>   exit:
> +	if (test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section))
> +		return 0;
> +
>   	return ret;

How is this not modifying the number of queues? From what I can tell, 
this returning success if we are in remove.

>   }
>   


More information about the Intel-wired-lan mailing list