[Intel-wired-lan] [PATCH net-next v2] iavf: Add helper to check if iavf_remove() is in progress

Jagielski, Jedrzej jedrzej.jagielski at intel.com
Thu Jun 9 08:04:21 UTC 2022


>On 6/8/2022 12:53 AM, Jedrzej Jagielski wrote:
>> From: Brett Creeley <brett.creeley at intel.com>
>> 
>> Currently the driver checks if the __IAVF_IN_REMOVE_TASK bit is set in
>> the adapter's crit_section bitmap. This is fine, but if the
>> implementation were to ever change, i.e. a mutex was introduced all of
>> the callers of test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section)
>> would have to change. Fix this by introducing the
>> iavf_is_remove_in_progress() helper function.
>
>If you want this to match what you sent in the original series [1], 
>please wait until the net patch [2] is applied before sending this. This 
>will allow you to change the __iavf_setup_tc() call as well.

Sure, I will send amended version after mentioned patch will
be applied to tree.

>
>> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski at intel.com>
>
>[1] 
>https://lore.kernel.org/intel-wired-lan/DM6PR11MB27315C25DD0EA44B086A5501F0DC9@DM6PR11MB2731.namprd11.prod.outlook.com/T/#mae4f93d5c5fcc6c3ef13f9e1af1938558f1e975f
>[2] 
>https://lore.kernel.org/intel-wired-lan/20220608095337.2986633-1-jedrzej.jagielski@intel.com/T/#u
>


More information about the Intel-wired-lan mailing list