[Intel-wired-lan] [PATCH net v2] iavf: Disallow changing rx/tx-frames and rx/tx-frames-irq

Tony Nguyen anthony.l.nguyen at intel.com
Fri Jun 10 17:32:28 UTC 2022



On 6/9/2022 3:01 PM, Jun Zhang wrote:
> From: Przemyslaw Patynowski <przemyslawx.patynowski at intel.com>
> 
> Remove support for rx/tx-frames and rx/tx-frames-irq as it is
> introducing counterintuitive settings and is not stated in any
> requirement.

I suggest remove the requirements portion; this doesn't really apply to 
the kernel.

> Remove from supported_coalesce_params ETHTOOL_COALESCE_MAX_FRAMES
> and ETHTOOL_COALESCE_MAX_FRAMES_IRQ. As tx-frames-irq allowed
> user to change budget for iavf_clean_tx_irq, remove work_limit
> and use define for budget.
> Without this patch there would be possiblity to change rx/tx-frames
> and rx/tx-frames-irq, which for rx/tx-frames did nothing, while for
> rx/tx-frames-irq it changed rx/tx-frames and only changed budget
> for cleaning NAPI poll.
> 

I missed this on v1, but where is the Fixes tag? All net bug fixes need one.

> Signed-off-by: Przemyslaw Patynowski <przemyslawx.patynowski at intel.com>
> Signed-off-by: Jun Zhang <xuejun.zhang at intel.com>



More information about the Intel-wired-lan mailing list