[Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control

[Mekala, SunithaX D]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Anatolii Gerasymenko
> Sent: Wednesday, June 29, 2022 11:27 PM
> To: Effron, Zvi <zeffron at riotgames.com>
> Cc: intel-wired-lan at lists.osuosl.org; Brouer, Jesper <brouer at redhat.com>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control
>
> On 28.06.2022 22:36, Zvi Effron wrote:
> On Tue, Jun 28, 2022 at 3:45 AM Anatolii Gerasymenko 
> <anatolii.gerasymenko at intel.com> wrote:
>>
>> Implement possibility to change FCS/CRC stripping feature using 
>> ethtool command.
>>
>> Having FCS/CRC could be useful for:
>> - network sniffers to inspect FCS/CRC correctness
>> - for benchmarking use cases
>> - XDP programs
>>
> 
> Have you thought of exposing this through the XDP hints paradigm that 
> Jesper is working on? That could make it available to XDP programs 
> that want it without breaking those that assume they won't have it, 
> allowing both programs to coexist on the same machine?
> 
>
> No, this hasn't been considered, thank you for the idea.
>
> 
>> Anatolii Gerasymenko (1):
>> ice: Implement FCS/CRC and VLAN stripping co-existence policy
>>
>> Jesse Brandeburg (1):
>> ice: Implement control of FCS/CRC stripping
>>
>> drivers/net/ethernet/intel/ice/ice.h | 1 + 
>> drivers/net/ethernet/intel/ice/ice_base.c | 2 +- 
>> drivers/net/ethernet/intel/ice/ice_ethtool.c | 5 +- 
>> drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++ 
>> drivers/net/ethernet/intel/ice/ice_lib.h | 2 + 
>> drivers/net/ethernet/intel/ice/ice_main.c | 73 ++++++++++++++++++-- 
>> drivers/net/ethernet/intel/ice/ice_txrx.h | 3 +-
>> 7 files changed, 96 insertions(+), 11 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mekala at intel.com> (A Contingent worker at Intel)