[Intel-wired-lan] [PATCH net-next v2 1/2] ice: Implement control of FCS/CRC stripping

[Mekala, SunithaX D]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Anatolii Gerasymenko
> Sent: Monday, July 11, 2022 5:11 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Brandeburg, Jesse <jesse.brandeburg at intel.com>; Gerasymenko, Anatolii <anatolii.gerasymenko at intel.com>
> Subject: [Intel-wired-lan] [PATCH net-next v2 1/2] ice: Implement control of FCS/CRC stripping
>
> From: Jesse Brandeburg <jesse.brandeburg at intel.com>
>
> The driver can allow the user to configure whether the CRC aka the FCS (Frame Check Sequence) is DMA'd to the host as part of the receive buffer.  The driver usually wants this feature disabled so that the hardware checks the FCS and strips it in order to save PCI bandwidth.
>
> Control the reception of FCS to the host using the command:
> ethtool -K eth0 rx-fcs <on|off>
>
> The default shown in ethtool -k eth0 | grep fcs; should be "off", as the hardware will drop any frame with a bad checksum, and DMA of the checksum is useless overhead especially for small packets.
>
> Testing Hints:
> test the FCS/CRC arrives with received packets using tcpdump -nnpi eth0 -xxxx and it should show crc data as the last 4 bytes of the packet. Can also use wireshark to turn on CRC checking and check the data is correct.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> Co-Developed-by: Anatolii Gerasymenko <anatolii.gerasymenko at intel.com>
> Signed-off-by: Anatolii Gerasymenko <anatolii.gerasymenko at intel.com>
> Acked-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> ---
> v2: rebase on top of Maciej Fijalkowski's patches
> ---
>  drivers/net/ethernet/intel/ice/ice.h         |  1 +
>  drivers/net/ethernet/intel/ice/ice_base.c    |  2 +-
>  drivers/net/ethernet/intel/ice/ice_ethtool.c |  5 +--
>  drivers/net/ethernet/intel/ice/ice_lib.c     | 21 ++++++++++
>  drivers/net/ethernet/intel/ice/ice_lib.h     |  2 +
>  drivers/net/ethernet/intel/ice/ice_main.c    | 40 ++++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_txrx.h    |  3 +-
>  7 files changed, 68 insertions(+), 6 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mekala at intel.com> (A Contingent worker at Intel)