[Intel-wired-lan] [PATCH net v5 1/2] ice: Fix VSIs unable to share unicast MAC

[Jagielski, Jedrzej]

>On 7/18/2022 9:42 AM, Jedrzej Jagielski wrote:
>> From: Anirudh Venkataramanan <anirudh.venkataramanan at intel.com>
>> 
>> The driver currently does not allow two VSIs in the same PF domain
>> to have the same unicast MAC address. This is incorrect in the sense
>> that a policy decision is being made in the driver when it must be
>> left to the user. This approach was causing issues when rebooting
>> the system with VFs spawned not being able to change their MAC addresses.
>> Such errors were present in dmesg:
>> 
>> [ 7921.068237] ice 0000:b6:00.2 ens2f2: Unicast MAC 6a:0d:e4:70:ca:d1 already
>> exists on this PF. Preventing setting VF 7 unicast MAC address to 6a:0d:e4:70:ca:d1
>> 
>> Fix that by removing this restriction. Doing this also allows
>> us to remove some additional code that's checking if a unicast MAC
>> filter already exists.
>> 
>> Rename ucast_shared to umac_shared, as "umac" is a more widely
>> used shorthand for "unicast MAC".
>
>Since this will be removed, lets not thrash the driver with this rename.
>
>> Also add a helper function to set this flag. This helper is
>> expected to be called by core drivers.
>
>and the helper.

OK, so can I resend the patch with no names changed and when the patch would
be applied into the tree I would send the second one removing umac_shared? 
Is that a good approach?

>
>> Fixes: 47ebc7b02485 ("ice: Check if unicast MAC exists before setting VF MAC")
>> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan at intel.com>
>> Signed-off-by: Sylwester Dziedziuch <sylwesterx.dziedziuch at intel.com>
>> Signed-off-by: Mateusz Palczewski <mateusz.palczewski at intel.com>
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski at intel.com>