[Intel-wired-lan] [net-next v2 0/2] devlink: implement dry run support for flash update
Jacob Keller
jacob.e.keller at intel.com
Thu Jul 21 21:14:45 UTC 2022
This is a re-send of the dry run support I submitted nearly a year ago at
https://lore.kernel.org/netdev/CO1PR11MB50898047B9C0FAA520505AFDD6B59@CO1PR11MB5089.namprd11.prod.outlook.com/
I had delayed sending this because of conflicting work in the ice driver at
the time, but then forgot about it and never got around to resubmitting it.
This adds a DEVLINK_ATTR_DRY_RUN which is used to indicate a request to
validate a potentially destructive operation without performing the actions
yet. In theory it could be used for other devlink operations in the future.
For flash update, it allows the user to validate a flash image, including
ensuring the driver for the device is willing to program it, without
actually committing an update yet.
There is an accompanying series for iproute2 which allows adding the dry-run
attribute. It does as Jakub suggested and checks the maximum attribute
before allowing the dry run in order to avoid accidentally performing a real
update on older kernels.
Changes since v1:
* Added maintainers to Cc (thanks for pointing out the script, Jiri!)
* Replaced bool in struct with u8 : 1
* Added kernel doc to devlink_flash_update_params
* Renamed PLDMFW parameter from dry_run to validate
* Reduced indentation in devlink.c by using nla_get_flag
Cc: Jacob Keller <jacob.e.keller at intel.com>
Cc: Jonathan Corbet <corbet at lwn.net>
Cc: Jiri Pirko <jiri at nvidia.com>
Cc: "David S. Miller" <davem at davemloft.net>
Cc: Eric Dumazet <edumazet at google.com>
Cc: Jakub Kicinski <kuba at kernel.org>
Cc: Paolo Abeni <pabeni at redhat.com>
Cc: Tony Nguyen <anthony.l.nguyen at intel.com>
Cc: David Ahern <dsahern at kernel.org>
Cc: Stephen Hemminger <stephen at networkplumber.org>
Cc: linux-doc at vger.kernel.org
Cc: netdev at vger.kernel.org
Cc: intel-wired-lan at lists.osuosl.org
Jacob Keller (2):
devlink: add dry run attribute to flash update
ice: support dry run of a flash update to validate firmware file
Documentation/driver-api/pldmfw/index.rst | 10 ++++++++
.../networking/devlink/devlink-flash.rst | 23 +++++++++++++++++++
drivers/net/ethernet/intel/ice/ice_devlink.c | 3 ++-
.../net/ethernet/intel/ice/ice_fw_update.c | 14 +++++++----
include/linux/pldmfw.h | 5 ++++
include/net/devlink.h | 4 ++++
include/uapi/linux/devlink.h | 8 +++++++
lib/pldmfw/pldmfw.c | 12 ++++++++++
net/core/devlink.c | 17 +++++++++++++-
9 files changed, 90 insertions(+), 6 deletions(-)
base-commit: 5588d628027092e66195097bdf6835ddf64418b3
--
2.35.1.456.ga9c7032d4631
More information about the Intel-wired-lan
mailing list