[Intel-wired-lan] [PATCH net v3 2/2] ice: Fix promiscuous mode not turning off

Szlosek, Marek marek.szlosek at intel.com
Fri Jul 22 10:29:04 UTC 2022



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Michal Wilczynski
> Sent: poniedziałek, 4 lipca 2022 15:12
> To: intel-wired-lan at lists.osuosl.org
> Cc: Wilczynski, Michal <michal.wilczynski at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v3 2/2] ice: Fix promiscuous mode not
> turning off
> 
> When trust is turned off for the VF, the expectation is that promiscuous and
> allmulticast filters are removed. Currently default VSI filter is not getting
> cleared in this flow.
> 
> Example:
> 
> ip link set enp236s0f0 vf 0 trust on
> ip link set enp236s0f0v0 promisc on
> ip link set enp236s0f0 vf 0 trust off
> /* promiscuous mode is still enabled on VF0 */
> 
> Remove switch filters for both cases.
> This commit fixes above behavior by removing default VSI filters and
> allmulticast filters when vf-true-promisc-support is OFF.
> 
> Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
> Signed-off-by: Michal Wilczynski <michal.wilczynski at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 79 ++++++++++++++++---
>  drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  3 +
>  drivers/net/ethernet/intel/ice/ice_virtchnl.c |  9 +--
>  3 files changed, 72 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> index 9038d2687ba6..8fd7c3e37f5e 100644
> --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c

Tested-by: Marek Szlosek <marek.szlosek at intel.com>


More information about the Intel-wired-lan mailing list