[Intel-wired-lan] [PATCH net v2] ice: Fix VF not able to send tagged traffic with no VLAN filters

Jankowski, Konrad0 konrad0.jankowski at intel.com
Tue Aug 16 11:28:59 UTC 2022



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Mateusz Palczewski
> Sent: Wednesday, August 3, 2022 10:43 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Dziedziuch, SylwesterX <sylwesterx.dziedziuch at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v2] ice: Fix VF not able to send tagged
> traffic with no VLAN filters
> 
> From: Sylwester Dziedziuch <sylwesterx.dziedziuch at intel.com>
> 
> VF was not able to send tagged traffic when it didn't have any VLAN
> interfaces and VLAN anti-spoofing was enabled.
> Fix this by allowing VFs with no VLAN filters to send tagged traffic. After VF
> adds a VLAN interface it will be able to send tagged traffic matching VLAN
> filters only.
> 
> Testing hints:
> 1. Spawn VF
> 2. Send tagged packet from a VF
> 3. The packet should be sent out and not dropped 4. Add a VLAN interface on
> VF 5. Send tagged packet on that VLAN interface 6. Packet should be sent out
> and not dropped 7. Send tagged packet with id different than VLAN interface
> 8. Packet should be dropped
> 
> Fixes: daf4dd16438b ("ice: Refactor spoofcheck configuration functions")
> Signed-off-by: Sylwester Dziedziuch <sylwesterx.dziedziuch at intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski at intel.com>
> ---
>  v2: Removed Unnecessary parentheses around 'vsi->type != ICE_VSI_VF'
>      Unfortunetly some lines must be over 80 char to make the code more
> readable
> ---
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 11 ++--
>  drivers/net/ethernet/intel/ice/ice_virtchnl.c | 57 ++++++++++++++++---
>  2 files changed, 57 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> index 2d6130af1d40..7775aaa8cc43 100644
> --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> @@ -707,13 +707,16 @@ static int ice_cfg_mac_antispoof(struct ice_vsi *vsi,

Tested-by: Konrad Jankowski <konrad0.jankowski at intel.com>



More information about the Intel-wired-lan mailing list