[Intel-wired-lan] [PATCH net v5 3/4] ice: Fix clearing of promisc mode with bridge over bond

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Grzegorz Siwik
> Sent: Friday, August 12, 2022 6:56 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Brandeburg, Jesse <jesse.brandeburg at intel.com>; Siwik, Grzegorz
> <grzegorz.siwik at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v5 3/4] ice: Fix clearing of promisc
> mode with bridge over bond
> 
> When at least two interfaces are bonded and a bridge is enabled on the
> bond, an error can occur when the bridge is removed and re-added. The
> reason for the error is because promiscuous mode was not fully cleared from
> the VLAN VSI in the hardware. With this change, promiscuous mode is
> properly removed when the bridge disconnects from bonding.
> 
> [ 1033.676359] bond1: link status definitely down for interface enp95s0f0,
> disabling it [ 1033.676366] bond1: making interface enp175s0f0 the new
> active one [ 1033.676369] device enp95s0f0 left promiscuous mode [
> 1033.676522] device enp175s0f0 entered promiscuous mode [ 1033.676901]
> ice 0000:af:00.0 enp175s0f0: Error setting Multicast promiscuous mode on VSI
> 6 [ 1041.795662] ice 0000:af:00.0 enp175s0f0: Error setting Multicast
> promiscuous mode on VSI 6 [ 1041.944826] bond1: link status definitely down
> for interface enp175s0f0, disabling it [ 1041.944874] device enp175s0f0 left
> promiscuous mode [ 1041.944918] bond1: now running without any active
> interface!
> 
> Fixes: c31af68a1b94 ("ice: Add outer_vlan_ops and VSI specific VLAN ops
> implementations")
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik at intel.com>
> Co-developed-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> Link: https://lore.kernel.org/all/CAK8fFZ7m-
> KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ at mail.gmail.com/
> ---
>  v2: Fixed error message when setting same promiscuous mode
> ---
>  v3: Fixed style issues, changed to return directly.
> ---
>  v4: Fixed problem with patch applying
> ---
>  v5: Fixed incorrect title patch issue
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c  |  6 +++++-
> drivers/net/ethernet/intel/ice/ice_main.c | 13 ++++++++++++-
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g at intel.com> (A Contingent worker at Intel)