[Intel-wired-lan] [PATCH net v5 4/4] ice: Ignore error message when setting same promiscuous mode

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Grzegorz Siwik
> Sent: Friday, August 12, 2022 6:56 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Mikailenko, Benjamin <benjamin.mikailenko at intel.com>; Siwik, Grzegorz
> <grzegorz.siwik at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v5 4/4] ice: Ignore error message when
> setting same promiscuous mode
> 
> From: Benjamin Mikailenko <benjamin.mikailenko at intel.com>
> 
> Commit 1273f89578f2 ("ice: Fix broken IFF_ALLMULTI handling") introduced
> new checks when setting/clearing promiscuous mode. But if the requested
> promiscuous mode setting already exists, an -EEXIST error message would be
> printed. This is incorrect because promiscuous mode is either on/off and
> shouldn't print an error when the requested configuration is already set.
> 
> This can happen when removing a bridge with two bonded interfaces and
> promiscuous most isn't fully cleared from VLAN VSI in hardware.
> 
> Fix this by ignoring cases where requested promiscuous mode exists.
> 
> Fixes: 1273f89578f2 ("ice: Fix broken IFF_ALLMULTI handling")
> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko at intel.com>
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik at intel.com>
> Link: https://lore.kernel.org/all/CAK8fFZ7m-
> KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ at mail.gmail.com/
> ---
>  v2: Fixed error message when setting same promiscuous mode
> ---
>  v3: Fixed style issues, changed to return directly.
> ---
>  v4: Fixed problem with patch applying
> ---
>  v5: Fixed incorrect title patch issue
> ---
>  drivers/net/ethernet/intel/ice/ice_fltr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g at intel.com> (A Contingent worker at Intel)