[Intel-wired-lan] [PATCH net v2] i40e: Fix set max_tx_rate when it is lower than 1 Mbps

Tony Nguyen anthony.l.nguyen at intel.com
Mon Aug 22 21:27:00 UTC 2022


On 8/19/2022 3:05 AM, Andrii Staikov wrote:
> From: Michal Jaron <michalx.jaron at intel.com>
> 
> Value max_tx_rate is converted from bytes to Mbps.
> When max_tx_rate was set to lower than 125000 bytes (1 Mbps)
> it was cut to 0 because of this conversion.
> 
> Add a check that if max_tx_rate is lower than 1 Mbps
> set this to minimum usable value of 50 Mbps.
> 
> The visible behavior of it is following: "Setting max tx rate to minimum usable value of 50Mbps."

Sorry, perhaps I was unclear on my comment. I meant, how does this 
issue/bug manifest itself before this patch?

i.e.
"When max_tx_rate was set to lower than 125000 bytes (1 Mbps) it was cut 
to 0 because of this conversion."

What happens because of this?

> Add defined constants.
> 
> Fixes: 5ecae4120a6b ("i40e: Refactor VF BW rate limiting")
> Signed-off-by: Michal Jaron <michalx.jaron at intel.com>
> Signed-off-by: Andrii Staikov <andrii.staikov at intel.com>


More information about the Intel-wired-lan mailing list