[Intel-wired-lan] [PATCH net v1] ice: Add set_termios tty operations handle to GNSS
Michal Michalik
michal.michalik at intel.com
Tue Aug 23 19:24:29 UTC 2022
Some third party tools (ex. ubxtool) tries to change GNSS TTY parameters
(ex. speed). While being optional implementation, without set_termios
handle this operation fails and prevent those third party tools from
working. TTY interface in ice driver is virtual and don't need any change
on set_termios, so is left empty. Add this mock to support all Linux TTY
APIs.
Fixes: 43113ff73453 ("ice: add TTY for GNSS module for E810T device")
Signed-off-by: Michal Michalik <michal.michalik at intel.com>
---
drivers/net/ethernet/intel/ice/ice_gnss.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/ethernet/intel/ice/ice_gnss.c b/drivers/net/ethernet/intel/ice/ice_gnss.c
index b5a7f24..c2dc5e5 100644
--- a/drivers/net/ethernet/intel/ice/ice_gnss.c
+++ b/drivers/net/ethernet/intel/ice/ice_gnss.c
@@ -404,11 +404,26 @@ static unsigned int ice_gnss_tty_write_room(struct tty_struct *tty)
return ICE_GNSS_TTY_WRITE_BUF;
}
+/**
+ * ice_gnss_tty_set_termios - mock for set_termios tty operations
+ * @tty: pointer to the tty_struct
+ * @new_termios: pointer to the new termios parameters
+ */
+static void
+ice_gnss_tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
+{
+ /* Some 3rd party tools (ex. ubxtool) want to change the TTY parameters.
+ * In our virtual interface (I2C communication over FW AQ) we don't have
+ * to change anything, but we need to implement it to unblock tools.
+ */
+}
+
static const struct tty_operations tty_gps_ops = {
.open = ice_gnss_tty_open,
.close = ice_gnss_tty_close,
.write = ice_gnss_tty_write,
.write_room = ice_gnss_tty_write_room,
+ .set_termios = ice_gnss_tty_set_termios,
};
/**
--
2.9.5
base-commit: f1e941dbf80a9b8bab0bffbc4cbe41cc7f4c6fb6
More information about the Intel-wired-lan
mailing list