[Intel-wired-lan] [PATCH net v2] iavf: Fix change VF's mac address
Jankowski, Konrad0
konrad0.jankowski at intel.com
Wed Sep 7 06:54:12 UTC 2022
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Mateusz Palczewski
> Sent: Thursday, September 1, 2022 4:32 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Dziedziuch, SylwesterX <sylwesterx.dziedziuch at intel.com>; Zulinski,
> NorbertX <norbertx.zulinski at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v2] iavf: Fix change VF's mac address
>
> From: Sylwester Dziedziuch <sylwesterx.dziedziuch at intel.com>
>
> Previously changing mac address gives false negative because ip link set
> <interface> address <MAC> return with
> RTNLINK: Permission denied.
> In iavf_set_mac was check if PF handled our mac set request, even before
> filter was added to list.
> Because this check returns always true and it never waits for PF's response.
>
> Move iavf_is_mac_handled to wait_event_interruptible_timeout instead of
> false. Now it will wait for PF's response and then check if address was added
> or rejected.
>
> Fixes: 35a2443d0910 ("iavf: Add waiting for response from PF in set mac")
> Signed-off-by: Sylwester Dziedziuch <sylwesterx.dziedziuch at intel.com>
> Co-developed-by: Norbert Zulinski <norbertx.zulinski at intel.com>
> Signed-off-by: Norbert Zulinski <norbertx.zulinski at intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski at intel.com>
> ---
> v2: Added missing signed-off-by, fixed commit message and moved
> parenthesis to the line where function is called
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 10aa99dfdcdb..0c89f16bf1e2 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
Tested-by: Konrad Jankowski <konrad0.jankowski at intel.com>
More information about the Intel-wired-lan
mailing list