[Intel-wired-lan] [PATCH net v5] i40e: Fix ethtool rx-flow-hash setting for X722
G, GurucharanX
gurucharanx.g at intel.com
Fri Sep 9 07:49:24 UTC 2022
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Mateusz Palczewski
> Sent: Tuesday, September 6, 2022 3:37 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Jaron, MichalX <michalx.jaron at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v5] i40e: Fix ethtool rx-flow-hash
> setting for X722
>
> From: Slawomir Laba <slawomirx.laba at intel.com>
>
> When enabling flow type for RSS hash via ethtool:
>
> ethtool -N $pf rx-flow-hash tcp4|tcp6|udp4|udp6 s|d
>
> the driver would fail to setup this setting on X722 device since it was using
> the mask on the register dedicated for X710 devices.
>
> Apply a different mask on the register when setting the RSS hash for the
> X722 device.
>
> When displaying the flow types enabled via ethtool:
>
> ethtool -n $pf rx-flow-hash tcp4|tcp6|udp4|udp6
>
> the driver would print wrong values for X722 device.
>
> Fix this issue by testing masks for X722 device in i40e_get_rss_hash_opts
> function.
>
> Fixes: eb0dd6e4a3b3 ("i40e: Allow RSS Hash set with less than four
> parameters")
> Signed-off-by: Slawomir Laba <slawomirx.laba at intel.com>
> Signed-off-by: Michal Jaron <michalx.jaron at intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski at intel.com>
> ---
> v5: Changed author and order of signed-off-by tags
> v4: Add missing fixes tag and updated kdoc
> v3: Split the patch series and send only this to net and refactor to next
> ---
> .../net/ethernet/intel/i40e/i40e_ethtool.c | 31 ++++++++++++++-----
> drivers/net/ethernet/intel/i40e/i40e_type.h | 4 +++
> 2 files changed, 27 insertions(+), 8 deletions(-)
>
Tested-by: Gurucharan <gurucharanx.g at intel.com> (A Contingent worker at Intel)
More information about the Intel-wired-lan
mailing list