[Intel-wired-lan] [PATCH next v6] ice: use GNSS subsystem instead of TTY

[Paul Menzel]

Dear Arkadiusz, dear Karol,


Thank you for the patch.

Am 13.10.22 um 01:41 schrieb Arkadiusz Kubalewski:

[…]

> diff --git a/Documentation/networking/device_drivers/ethernet/intel/ice.rst b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> index dc2e60ced927..18c6c0660375 100644
> --- a/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> +++ b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> @@ -903,13 +903,13 @@ To enable/disable UDP Segmentation Offload, issue the following command::
>   
>   GNSS module
>   -----------
> -Allows user to read messages from the GNSS module and write supported commands.
> -If the module is physically present, driver creates 2 TTYs for each supported
> -device in /dev, ttyGNSS_<device>:<function>_0 and _1. First one (_0) is RW and
> -the second one is RO.
> -The protocol of write commands is dependent on the GNSS module as the driver
> -writes raw bytes from the TTY to the GNSS i2c. Please refer to the module
> -documentation for details.
> +Requires kernel compiled with CONFIG_GNSS=y or CONFIG_GNSS=m.
> +Allows user to read messages from the GNSS hardware module and write supported
> +commands. If the module is physically present, a GNSS device is spawned:
> +/dev/gnss<id>.

Please mark this up as code (monospace) with ``/dev/gnss<id>``.

Please also add a blank line between paragraphs.

> +The protocol of write command is dependent on the GNSS hardware module as the
> +driver writes raw bytes by the GNSS object to the receiver through i2c. Please
> +refer to the hardware GNSS module documentation for configuration details.

[…]


Kind regards,

Paul