[Intel-wired-lan] [PATCH net-next v4 2/2] ice: Handle LLDP MIB Pending change

Arland, ArpanaX arpanax.arland at intel.com
Mon Dec 19 08:18:47 UTC 2022


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Gerasymenko, Anatolii
> Sent: Wednesday, August 24, 2022 5:37 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Gerasymenko, Anatolii <anatolii.gerasymenko at intel.com>
> Subject: [Intel-wired-lan] [PATCH net-next v4 2/2] ice: Handle LLDP MIB Pending change
>
> If the number of Traffic Classes (TC) is decreased, the FW will no longer remove TC nodes, but will send a pending change notification. This will allow RDMA to destroy corresponding Control QP markers. After RDMA finishes outstanding operations, the ice driver will send an execute MIB Pending change admin queue command to FW to finish DCB configuration change.
>
> The FW will buffer all incoming Pending changes, so there can be only one active Pending change.
>
> RDMA driver guarantees to remove Control QP markers within 5000 ms.
> Hence, LLDP response timeout txTTL (default 30 sec) will be met.
>
> In the case of a Pending change, LLDP MIB Change Event (opcode 0x0A01) will contain the whole new MIB. But Get LLDP MIB (opcode 0x0A00) AQ call would still return an old MIB, as the Pending change hasn't been applied yet.
> Add ice_get_dcb_cfg_from_mib_change() function to retrieve DCBX config from LLDP MIB Change Event's buffer for Pending changes.
>
> Co-developed-by: Dave Ertman <david.m.ertman at intel.com>
> Signed-off-by: Dave Ertman <david.m.ertman at intel.com>
> Signed-off-by: Anatolii Gerasymenko <anatolii.gerasymenko at intel.com>
> ---
> v2: Remove inline hint for ice_dcb_is_mib_change_pending()
> v3: Handle only local LLDP MIB Pending change
> v4: Use the old way to get MIB content for non-Pending changes, because
>	the MIB Change event will not always contain a correct MIB.
> ---
>  drivers/net/ethernet/intel/ice/ice_dcb.c     | 36 +++++++++++
>  drivers/net/ethernet/intel/ice/ice_dcb.h     |  2 +
>  drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 68 +++++++++++++++-----
>  3 files changed, 91 insertions(+), 15 deletions(-)
>
Tested-by: Arpana Arland < arpanax.arland at intel.com> (A Contingent worker at Intel)


More information about the Intel-wired-lan mailing list