[Intel-wired-lan] [net-next v2 1/1] ice: Move support DDP code out of ice_flex_pipe.c

[Nguyen, Anthony L]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Sergey Temerkhanov
> Sent: Saturday, December 17, 2022 2:10 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Temerkhanov, Sergey <sergey.temerkhanov at intel.com>
> Subject: [Intel-wired-lan] [net-next v2 1/1] ice: Move support DDP code out
> of ice_flex_pipe.c
> 
> Currently, ice_flex_pipe.c includes the DDP loading functions
> and has grown large. Although flexible processing support
> code is related to DDP loading, these parts are distinct.
> Move the DDP loading functionality from ice_flex_pipe.c to
> a seperate file.
> 
> V2: Incorporate latest changes
> 
> Signed-off-by: Sergey Temerkhanov <sergey.temerkhanov at intel.com>
> ---

[...]

> +
> +/**
> + * ice_chk_pkg_version - check package version for compatibility with driver
> + * @pkg_ver: pointer to a version structure to check
> + *
> + * Check to make sure that the package about to be downloaded is
> compatible with
> + * the driver. To be compatible, the major and minor components of the
> package
> + * version must match our ICE_PKG_SUPP_VER_MAJ and
> ICE_PKG_SUPP_VER_MNR
> + * definitions.
> + */
> +/**
> + * ice_chk_pkg_version - check package version for compatibility with driver
> + * @pkg_ver: pointer to a version structure to check
> + *
> + * Check to make sure that the package about to be downloaded is
> compatible with
> + * the driver. To be compatible, the major and minor components of the
> package
> + * version must match our ICE_PKG_SUPP_VER_MAJ and
> ICE_PKG_SUPP_VER_MNR
> + * definitions.
> + */

There's double kdoc here. I assume that's why this warning is popping up:

warning: Incorrect use of kernel-doc format:  * ice_chk_pkg_version - check package version for compatibility with driver

> +static enum ice_ddp_state ice_chk_pkg_version(struct ice_pkg_ver
> *pkg_ver)
> +{
> +	if (pkg_ver->major > ICE_PKG_SUPP_VER_MAJ ||
> +	    (pkg_ver->major == ICE_PKG_SUPP_VER_MAJ &&
> +	     pkg_ver->minor > ICE_PKG_SUPP_VER_MNR))
> +		return ICE_DDP_PKG_FILE_VERSION_TOO_HIGH;
> +	else if (pkg_ver->major < ICE_PKG_SUPP_VER_MAJ ||
> +		 (pkg_ver->major == ICE_PKG_SUPP_VER_MAJ &&
> +		  pkg_ver->minor < ICE_PKG_SUPP_VER_MNR))
> +		return ICE_DDP_PKG_FILE_VERSION_TOO_LOW;
> +
> +	return ICE_DDP_PKG_SUCCESS;
> +}
> +

[...]

> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-
> 07-52-316 | Kapital zakladowy 200.000 PLN.
> Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu
> ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w
> transakcjach handlowych.
> 
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> adresata i moze zawierac informacje poufne. W razie przypadkowego
> otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale
> jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest
> zabronione.
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). If you are not the intended recipient,
> please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.

This footer still needs to be removed.

> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan