[Intel-wired-lan] [PATCH net-next v2 00/10] implement devlink reload in ice

Tue Dec 20 16:51:51 UTC 2022

On 12/16/2022 12:43 AM, Michal Swiatkowski wrote:
> Hi,
> 
> This is a part of changes done in patchset [0]. Resource management is
> kind of controversial part, so I split it into two patchsets.
> 
> It is the first one, covering refactor and implement reload API call.
> The refactor will unblock some of the patches needed by SIOV or
> subfunction.
> 
> Most of this patchset is about implementing driver reload mechanism.
> Part of code from probe and rebuild is used to not duplicate code.
> To allow this reuse probe and rebuild path are split into smaller
> functions.
> 
> Patch "ice: split ice_vsi_setup into smaller functions" changes
> boolean variable in function call to integer and adds define
> for it. Instead of having the function called with true/false now it
> can be called with readable defines ICE_VSI_FLAG_INIT or
> ICE_VSI_FLAG_NO_INIT. It was suggested by Jacob Keller and probably this
> mechanism will be implemented across ice driver in follow up patchset.
> 
> Previously the code was reviewed here [0].
> 
> [0] https://lore.kernel.org/netdev/Y3ckRWtAtZU1BdXm@unreal/T/#m3bb8feba0a62f9b4cd54cd94917b7e2143fc2ecd
> 
> v1 --> v2:
>   * fix crash caused by merger error with VSI statistic

I'm seeing a crash on unload of the driver

[  599.769412] ------------[ cut here ]------------
[  599.769413] kernel BUG at lib/list_debug.c:53!
[  599.769438] invalid opcode: 0000 [#1] PREEMPT SMP PTI
[  599.769454] CPU: 87 PID: 1803 Comm: rmmod Not tainted 6.1.0+ #13
[  599.769469] Hardware name: Intel Corporation S2600WFT/S2600WFT, BIOS 
SE5C620.86B.00.01.0014.070920180847 07/09/2018
[  599.769486] RIP: 0010:__list_del_entry_valid.cold+0x5c/0x6f
[  599.769507] Code: e8 ad 7a fd ff 0f 0b 48 89 fe 48 89 ca 48 c7 c7 68 
8b 68 ad e8 99 7a fd ff 0f 0b 48 89 fe 48 c7 c7 30 8b 68 ad e8 88 7a fd 
ff <0f> 0b 48 89 fe 48 c7 c7 00 8b 68 ad e8 77 7a fd ff 0f 0b 41 0f b6
[  599.769539] RSP: 0018:ffffa9bb8cf83d90 EFLAGS: 00010286
[  599.769552] RAX: 000000000000004e RBX: ffff9cb73e835bc8 RCX: 
0000000000000000
[  599.769567] RDX: 0000000000000001 RSI: ffffffffad66efcd RDI: 
00000000ffffffff
[  599.769581] RBP: ffff9cb73e835b80 R08: 0000000000000000 R09: 
00000000ffff7fff
[  599.769595] R10: ffffa9bb8cf83c60 R11: ffff9ce5dfdfffe8 R12: 
ffff9cb73e835bc8
[  599.769609] R13: ffff9cb7340694f8 R14: ffff9cb734068f5c R15: 
0000000000000bf8
[  599.769623] FS:  00007ff3f03fd740(0000) GS:ffff9ce5dfcc0000(0000) 
knlGS:0000000000000000
[  599.769638] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  599.769651] CR2: 0000563a8b9ec378 CR3: 0000001858ba4003 CR4: 
00000000007706e0
[  599.769665] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 
0000000000000000
[  599.769679] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 
0000000000000400
[  599.769693] PKRU: 55555554
[  599.769701] Call Trace:
[  599.769711]  <TASK>
[  599.769718]  devl_region_destroy+0x38/0x80
[  599.769737]  devlink_region_destroy+0x25/0x30
[  599.769751]  ice_devlink_destroy_regions+0x17/0x40 [ice]
[  599.769797]  ice_remove+0x22c/0x2b0 [ice]
[  599.769822]  pci_device_remove+0x33/0xa0
[  599.769837]  device_release_driver_internal+0x1aa/0x230
[  599.769856]  driver_detach+0x44/0x90
[  599.769867]  bus_remove_driver+0x55/0xe0
[  599.769877]  pci_unregister_driver+0x2a/0xb0
[  599.769889]  ice_module_exit+0xc/0x510 [ice]
[  599.769919]  __do_sys_delete_module.constprop.0+0x177/0x2e0
[  599.769935]  ? exit_to_user_mode_prepare+0x155/0x200
[  599.769948]  do_syscall_64+0x38/0x90
[  599.769962]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
[  599.769977] RIP: 0033:0x7ff3f011283b
[  599.769989] Code: 73 01 c3 48 8b 0d ed 75 0e 00 f7 d8 64 89 01 48 83 
c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 
05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d bd 75 0e 00 f7 d8 64 89 01 48
[  599.770019] RSP: 002b:00007ffe91fbce38 EFLAGS: 00000206 ORIG_RAX: 
00000000000000b0
[  599.770036] RAX: ffffffffffffffda RBX: 0000563a8b9e1750 RCX: 
00007ff3f011283b
[  599.770052] RDX: 000000000000000a RSI: 0000000000000800 RDI: 
0000563a8b9e17b8
[  599.770067] RBP: 0000000000000000 R08: 0000000000000000 R09: 
0000000000000000
[  599.770080] R10: 00007ff3f01a3ac0 R11: 0000000000000206 R12: 
00007ffe91fbd0b0
[  599.770095] R13: 00007ffe91fbd6d4 R14: 0000563a8b9e12a0 R15: 
0000563a8b9e1750
[  599.770528]  </TASK>
[  599.770824] Modules linked in: rpcrdma sunrpc rdma_ucm ib_srpt 
ib_isert iscsi_target_mod target_core_mod ib_iser libiscsi 
scsi_transport_iscsi rdma_cm iw_cm ib_cm rfkill intel_rapl_msr 
intel_rapl_common intel_uncore_frequency intel_uncore_frequency_common 
isst_if_common skx_edac nfit libnvdimm ib_uverbs vfat 
x86_pkg_temp_thermal ib_core fat intel_powerclamp iTCO_wdt intel_pmc_bxt 
coretemp iTCO_vendor_support rapl ipmi_ssif intel_cstate ice(-) 
intel_uncore i40e i2c_i801 mei_me joydev pcspkr gnss i2c_smbus lpc_ich 
ioatdma mei acpi_ipmi intel_pch_thermal dca ipmi_si acpi_power_meter 
acpi_pad fuse zram ip_tables ast drm_kms_helper i2c_algo_bit 
drm_shmem_helper drm crct10dif_pclmul crc32_pclmul crc32c_intel 
ghash_clmulni_intel sha512_ssse3 wmi ipmi_devintf ipmi_msghandler [last 
unloaded: irdma]
[  599.772846] ---[ end trace 0000000000000000 ]---