[Intel-wired-lan] [PATCH net v1] ice: Reset stats on queue change

[Benjamin Mikailenko]

On 12/20/2022 9:08 AM, Alexander Lobakin wrote:
> From: Benjamin Mikailenko <benjamin.mikailenko at intel.com>
> Date: Tue, 20 Dec 2022 11:05:06 -0500
> 
>> Commit 288ecf491b16 ("ice: Accumulate ring statistics over reset")
>> implemented functionality for interface statistics to persist over reset.
>> This avoided the case where a reset happens in the background, statistics
>> set to zero, and the user checks ring statistics expecting them to be
>> populated.
>>
>> In the case of changing the number of queues, statistics should reset.
>> This is because old data should clear after parameter reconfiguration.
> 
> "Should clear" -- because? Who said that? Stats are usually a
> netdev-lifetime entity (or even pcidev-lifetime).
> 
>>
>> Fix this by resetting statistics when the number of queues changes.
>>
>> Fixes: 288ecf491b16 ("ice: Accumulate ring statistics over reset")
> 
> It's not even clear why resets are needed, not speaking of if it
> actually fixes anything. I think this wouldn't hit the net-fixes
> tree with no real scenario where the mentioned commit provides a
> serious regression.
> 

Hello Olek, thanks for the review! I updated the commit message in v2
explaining better why resets occur without user interaction, how the
issue was reproducible using ethtool, and added some better wording.

>> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko at intel.com>
>> ---
>>  drivers/net/ethernet/intel/ice/ice_lib.c | 65 ++++++++++++++++++++++++
>>  1 file changed, 65 insertions(+)
> 
> [...]
> 
>> -- 
>> 2.34.3
> 
> Thanks,
> Olek

Thank you,
Ben