[Intel-wired-lan] [PATCH net v2] ice: Reset stats on queue change

[Alexander Lobakin]

From: Benjamin Mikailenko <benjamin.mikailenko at intel.com>
Date: Tue, 20 Dec 2022 13:46:18 -0500

> Commit 288ecf491b16 ("ice: Accumulate ring statistics over reset")
> implemented functionality for interface statistics to persist over reset.
> This avoided the case where a reset happens in the background (for example
> a tx hang occourred triggering a reset), statistics set to zero, and the
> user checks ring statistics expecting them to be populated.
> 
> In the case of changing queues (for example "ethtool -L ethX combined 5"),
> this change caused statistics in the remaining queues (0-4) to persist. In
> this case, statistics should reset.
> 
> Fix this by clearing statistics when the number of queues changes.

Oh, sorry for the bad wording in my reply to v1. My question was
mainly why is it an issue that the statistics for the queues that
the user didn't touch doesn't get reset? As an user, I'd expect
the stats to persist if I didn't do anything with a queue, and in
case of reducing or increasing the queue count let's say between
3 and 8 I don't expect queues 0-2 to be changed anyhow.
So I realize what this commit is about and what it does do, but
I don't see any clear reasons for now why we should do that.

> 
> Fixes: 288ecf491b16 ("ice: Accumulate ring statistics over reset")
> Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko at intel.com>
> ---
> v2: Edited commit message
> 
>  drivers/net/ethernet/intel/ice/ice_lib.c | 65 ++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)

[...]

> -- 
> 2.34.3

Thanks,
Olek