[Intel-wired-lan] [net-next] ice: remove comment about not supporting driver reinit
Michal Swiatkowski
michal.swiatkowski at linux.intel.com
Tue Feb 28 05:42:55 UTC 2023
On Mon, Feb 27, 2023 at 02:15:00PM -0800, Jacob Keller wrote:
> Since commit 31c8db2c4fa7 ("ice: implement devlink reinit action"), the ice
> driver does support driver re-initialization via devlink reload. Remove the
> stale comment indicating that the driver lacks this support from the
> ice_devlink_ops structure.
>
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Cc: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_devlink.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c
> index 05f216af8c81..bc44cc220818 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devlink.c
> +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c
> @@ -1254,7 +1254,6 @@ static const struct devlink_ops ice_devlink_ops = {
> .supported_flash_update_params = DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK,
> .reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
> BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE),
> - /* The ice driver currently does not support driver reinit */
> .reload_down = ice_devlink_reload_down,
> .reload_up = ice_devlink_reload_up,
> .port_split = ice_devlink_port_split,
>
> base-commit: f75ed9add58c1bca6a615609a0f7f148c257e3c7
> --
Thanks for fixing it.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> 2.39.1.405.gd4c25cc71f83
>
More information about the Intel-wired-lan
mailing list