[Intel-wired-lan] [PATCH net-next] ice: Fix implicit cast u32 to u16

Paul Menzel pmenzel at molgen.mpg.de
Tue Feb 28 10:01:00 UTC 2023


Dear Kalyan, dear Marcin,


Am 28.02.23 um 09:49 schrieb Kalyan Kodamagula:
> From: Marcin Szycik <marcin.szycik at intel.com>
> 
> Fix implicit cast by changing argument types of two functions to correct
> types.
> 
> Signed-off-by: Marcin Szycik <marcin.szycik at intel.com>
> Signed-off-by: Kalyan Kodamagula <kalyan.kodamagula at intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_ddp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ddp.c b/drivers/net/ethernet/intel/ice/ice_ddp.c
> index d71ed210f9c4..830fa53b5e0a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ddp.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ddp.c
> @@ -701,14 +701,14 @@ struct ice_buf_build *ice_pkg_buf_alloc(struct ice_hw *hw)
>   	return bld;
>   }
>   
> -static bool ice_is_gtp_u_profile(u16 prof_idx)
> +static bool ice_is_gtp_u_profile(u32 prof_idx)
>   {
>   	return (prof_idx >= ICE_PROFID_IPV6_GTPU_TEID &&
>   		prof_idx <= ICE_PROFID_IPV6_GTPU_IPV6_TCP_INNER) ||
>   	       prof_idx == ICE_PROFID_IPV4_GTPU_TEID;
>   }
>   
> -static bool ice_is_gtp_c_profile(u16 prof_idx)
> +static bool ice_is_gtp_c_profile(u32 prof_idx)
>   {
>   	switch (prof_idx) {
>   	case ICE_PROFID_IPV4_GTPC_TEID:

Is there a reason to limit the length or could `unsigned int` be used?


Kind regards,

Paul


More information about the Intel-wired-lan mailing list