[Intel-wired-lan] [PATCH net v3] ice: copy last block omitted in ice_get_module_eeprom()

Alexander Lobakin aleksander.lobakin at intel.com
Fri Mar 3 11:12:40 UTC 2023


From: Petr Oros <poros at redhat.com>
Date: Wed,  1 Mar 2023 21:47:07 +0100

> ice_get_module_eeprom() is broken since commit e9c9692c8a81 ("ice:
> Reimplement module reads used by ethtool") In this refactor,
> ice_get_module_eeprom() reads the eeprom in blocks of size 8.
> But the condition that should protect the buffer overflow
> ignores the last block. The last block always contains zeros.

[...]

> Fixes: e9c9692c8a81 ("ice: Reimplement module reads used by ethtool")
> Signed-off-by: Petr Oros <poros at redhat.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin at intel.com>

> ---
> v2: memcpy unified calls
> v3: copy_len is now declared in if scope
>     unwrapped line before memcpy
[...]

Thanks,
Olek


More information about the Intel-wired-lan mailing list