[Intel-wired-lan] [PATCH net-next v1] ice: don't ignore return codes in VSI related code

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Michal Swiatkowski
> Sent: Monday, February 13, 2023 4:58 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Dan Carpenter <error27 at gmail.com>
> Subject: [Intel-wired-lan] [PATCH net-next v1] ice: don't ignore return codes
> in VSI related code
> 
> There were few smatch warnings reported by Dan:
> - ice_vsi_cfg_xdp_txqs can return 0 instead of ret, which is cleaner
> - return values in ice_vsi_cfg_def were ignored
> - in ice_vsi_rebuild return value was ignored in case rebuild failed,
>   it was a never reached code, however, rewrite it for clarity.
> - ice_vsi_cfg_tc can return 0 instead of ret
> 
> Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
> Reported-by: Dan Carpenter <error27 at gmail.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 

Tested-by: Gurucharan G <gurucharanx.g at intel.com> (A Contingent worker at Intel)