[Intel-wired-lan] [PATCH net-next v9 5/5] ice: add ability to enable FW logging and capture data

[Tony Nguyen]

On 3/2/2023 1:51 PM, Paul M Stillwell Jr wrote:
> Once the FW logging is configured then users need to be able to enable
> logging and capture the data. To enable/disable FW logging use 'enable
> fwlog' and 'disable fwlog'. An example command to enable FW logging:
> 
> echo enable fwlog > /sys/kernel/debug/ice/0000\:18\:00.0/fwlog
> 
> Once logging is enable the user should read the data using something
> like:
> 
> cat /sys/kernel/debug/ice/0000\:18\:00.0/fwlog > log_data.bin

There should be documentation for this feature; 
Documentation/networking/device_drivers/ethernet/intel/ice.rst?

> The output file is a binary file that will be decoded by the FW
> team for debugging.

Perhaps 'by Intel' instead of 'by the FW team'
> 
> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr at intel.com>
> ---

[...]

> index a611e0d98bd0..68ab19678dbe 100644
> --- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> +++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
> @@ -2075,7 +2075,9 @@ enum ice_aqc_fw_logging_mod {
>   };
>   
>   /* Set FW Logging configuration (indirect 0xFF30)
> + * Register for FW Logging (indirect 0xFF31)

This should go with the patch that added the 
'ice_aqc_opc_fw_logs_register			= 0xFF31,'

entry...

Also, the defines related to the command should be brought in with the 
command instead of all at the beginning.

(These:
+#define ICE_AQC_FW_LOG_CONF_UART_EN	BIT(0)
+#define ICE_AQC_FW_LOG_CONF_AQ_EN	BIT(1)
+#define ICE_AQC_FW_LOG_QUERY_REGISTERED	BIT(2)
+#define ICE_AQC_FW_LOG_CONF_SET_VALID	BIT(3)
+#define ICE_AQC_FW_LOG_AQ_REGISTER	BIT(0)
+#define ICE_AQC_FW_LOG_AQ_QUERY		BIT(2)
+#define ICE_AQC_FW_LOG_PERSISTENT	BIT(0)
)

>    * Query FW Logging (indirect 0xFF32)
> + * FW Log Event (indirect 0xFF33)
>    */
>   struct ice_aqc_fw_log {
>   	u8 cmd_flags;
> @@ -2375,6 +2377,7 @@ enum ice_adminq_opc {
>   	ice_aqc_opc_fw_logs_config			= 0xFF30,
>   	ice_aqc_opc_fw_logs_register			= 0xFF31,
>   	ice_aqc_opc_fw_logs_query			= 0xFF32,
> +	ice_aqc_opc_fw_logs_event			= 0xFF33,
>   };
>