[Intel-wired-lan] [PATCH v3] netdevice: use ifmap instead of plain fields

kernel test robot lkp at intel.com
Sat Mar 4 15:05:51 UTC 2023


Hi Vincenzo,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master horms-ipvs/master linus/master v6.2 next-20230303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincenzo-Palazzo/netdevice-use-ifmap-instead-of-plain-fields/20230304-195731
patch link:    https://lore.kernel.org/r/20230304115626.215026-1-vincenzopalazzodev%40gmail.com
patch subject: [PATCH v3] netdevice: use ifmap instead of plain fields
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230304/202303042257.q7Wn15nV-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/89e04810927e646944e5cdd83fb9bb5a41cc5a3d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vincenzo-Palazzo/netdevice-use-ifmap-instead-of-plain-fields/20230304-195731
        git checkout 89e04810927e646944e5cdd83fb9bb5a41cc5a3d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp at intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303042257.q7Wn15nV-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:564,
                    from include/linux/kernel.h:29,
                    from drivers/net/arcnet/com20020_cs.c:37:
   drivers/net/arcnet/com20020_cs.c: In function 'com20020_config':
>> drivers/net/arcnet/com20020_cs.c:268:25: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'int' [-Wformat=]
     268 |         netdev_dbg(dev, "port %#3lx, irq %d\n",
         |                         ^~~~~~~~~~~~~~~~~~~~~~
     269 |                    dev->dev_mapping.base_addr, dev->irq);
         |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                    |
         |                                    int
   include/linux/dynamic_debug.h:223:29: note: in definition of macro '__dynamic_func_call_cls'
     223 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
     249 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:276:9: note: in expansion of macro '_dynamic_func_call'
     276 |         _dynamic_func_call(fmt, __dynamic_netdev_dbg,           \
         |         ^~~~~~~~~~~~~~~~~~
   include/net/net_debug.h:57:9: note: in expansion of macro 'dynamic_netdev_dbg'
      57 |         dynamic_netdev_dbg(__dev, format, ##args);              \
         |         ^~~~~~~~~~~~~~~~~~
   drivers/net/arcnet/com20020_cs.c:268:9: note: in expansion of macro 'netdev_dbg'
     268 |         netdev_dbg(dev, "port %#3lx, irq %d\n",
         |         ^~~~~~~~~~
   drivers/net/arcnet/com20020_cs.c:268:35: note: format string is defined here
     268 |         netdev_dbg(dev, "port %#3lx, irq %d\n",
         |                               ~~~~^
         |                                   |
         |                                   long unsigned int
         |                               %#3x


vim +268 drivers/net/arcnet/com20020_cs.c

^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  194  
15b99ac1729503 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2006-03-31  195  static int com20020_config(struct pcmcia_device *link)
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  196  {
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  197  	struct arcnet_local *lp;
2dfd2533e9e700 drivers/net/arcnet/com20020_cs.c Himangi Saraogi   2014-08-09  198  	struct com20020_dev *info;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  199  	struct net_device *dev;
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  200  	int i, ret;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  201  	int ioaddr;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  202  
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  203  	info = link->priv;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  204  	dev = info->dev;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  205  
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  206  	dev_dbg(&link->dev, "config...\n");
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  207  
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  208  	dev_dbg(&link->dev, "com20020_config\n");
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  209  
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  210  	dev_dbg(&link->dev, "baseport1 is %Xh\n",
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  211  		(unsigned int)link->resource[0]->start);
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  212  
4c89e88bfde6a3 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2008-08-03  213  	i = -ENODEV;
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  214  	link->io_lines = 16;
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  215  
7f5e760c1b2690 drivers/net/arcnet/com20020_cs.c Joe Perches       2015-05-05  216  	if (!link->resource[0]->start) {
7f5e760c1b2690 drivers/net/arcnet/com20020_cs.c Joe Perches       2015-05-05  217  		for (ioaddr = 0x100; ioaddr < 0x400; ioaddr += 0x10) {
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  218  			link->resource[0]->start = ioaddr;
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  219  			i = pcmcia_request_io(link);
4c89e88bfde6a3 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2008-08-03  220  			if (i == 0)
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  221  				break;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  222  		}
7f5e760c1b2690 drivers/net/arcnet/com20020_cs.c Joe Perches       2015-05-05  223  	} else {
90abdc3b973229 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-24  224  		i = pcmcia_request_io(link);
7f5e760c1b2690 drivers/net/arcnet/com20020_cs.c Joe Perches       2015-05-05  225  	}
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  226  
7f5e760c1b2690 drivers/net/arcnet/com20020_cs.c Joe Perches       2015-05-05  227  	if (i != 0) {
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  228  		dev_dbg(&link->dev, "requestIO failed totally!\n");
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  229  		goto failed;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  230  	}
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  231  
89e04810927e64 drivers/net/arcnet/com20020_cs.c Vincenzo Palazzo  2023-03-04  232  	/* FIXME: multiple assignments should be avoided */
89e04810927e64 drivers/net/arcnet/com20020_cs.c Vincenzo Palazzo  2023-03-04  233  	ioaddr = dev->dev_mapping.base_addr = link->resource[0]->start;
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  234  	dev_dbg(&link->dev, "got ioaddr %Xh\n", ioaddr);
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  235  
5fa9167a1bf5f5 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-11-08  236  	dev_dbg(&link->dev, "request IRQ %d\n",
eb14120f743d29 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-03-07  237  		link->irq);
7f5e760c1b2690 drivers/net/arcnet/com20020_cs.c Joe Perches       2015-05-05  238  	if (!link->irq) {
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  239  		dev_dbg(&link->dev, "requestIRQ failed totally!\n");
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  240  		goto failed;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  241  	}
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  242  
eb14120f743d29 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-03-07  243  	dev->irq = link->irq;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  244  
1ac71e5a35eebe drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2010-07-29  245  	ret = pcmcia_enable_device(link);
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  246  	if (ret)
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  247  		goto failed;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  248  
7f5e760c1b2690 drivers/net/arcnet/com20020_cs.c Joe Perches       2015-05-05  249  	if (com20020_check(dev)) {
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  250  		regdump(dev);
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  251  		goto failed;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  252  	}
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  253  
4cf1653aa90c63 drivers/net/pcmcia/com20020_cs.c Wang Chen         2008-11-12  254  	lp = netdev_priv(dev);
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  255  	lp->card_name = "PCMCIA COM20020";
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  256  	lp->card_flags = ARC_CAN_10MBIT; /* pretend all of them can 10Mbit */
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  257  
dd2e5a156525f1 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-11-03  258  	SET_NETDEV_DEV(dev, &link->dev);
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  259  
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  260  	i = com20020_found(dev, 0);	/* calls register_netdev */
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  261  
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  262  	if (i != 0) {
636b8116d4e116 drivers/net/pcmcia/com20020_cs.c Joe Perches       2010-08-12  263  		dev_notice(&link->dev,
636b8116d4e116 drivers/net/pcmcia/com20020_cs.c Joe Perches       2010-08-12  264  			   "com20020_found() failed\n");
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  265  		goto failed;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  266  	}
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  267  
636b8116d4e116 drivers/net/pcmcia/com20020_cs.c Joe Perches       2010-08-12 @268  	netdev_dbg(dev, "port %#3lx, irq %d\n",
89e04810927e64 drivers/net/arcnet/com20020_cs.c Vincenzo Palazzo  2023-03-04  269  		   dev->dev_mapping.base_addr, dev->irq);
15b99ac1729503 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2006-03-31  270  	return 0;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  271  
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  272  failed:
dd0fab5b940c0b drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2009-10-24  273  	dev_dbg(&link->dev, "com20020_config failed...\n");
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  274  	com20020_release(link);
15b99ac1729503 drivers/net/pcmcia/com20020_cs.c Dominik Brodowski 2006-03-31  275  	return -ENODEV;
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  276  } /* com20020_config */
^1da177e4c3f41 drivers/net/pcmcia/com20020_cs.c Linus Torvalds    2005-04-16  277  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests


More information about the Intel-wired-lan mailing list