[Intel-wired-lan] [PATCH] igb: revert rtnl_lock() that causes deadlock
Corinna Vinschen
vinschen at redhat.com
Tue Mar 7 13:45:02 UTC 2023
On Mar 7 21:05, Lin Ma wrote:
> The commit 6faee3d4ee8b ("igb: Add lock to avoid data race") adds
> rtnl_lock to eliminate a false data race shown below
>
> (FREE from device detaching) | (USE from netdev core)
> igb_remove | igb_ndo_get_vf_config
> igb_disable_sriov | vf >= adapter->vfs_allocated_count?
> kfree(adapter->vf_data) |
> adapter->vfs_allocated_count = 0 |
> | memcpy(... adapter->vf_data[vf]
>
> The above race will never happen and the extra rtnl_lock causes deadlock
> below
> [...]
> CC: stable at vger.kernel.org
> Fixes: 6faee3d4ee8b ("igb: Add lock to avoid data race")
> Reported-by: Corinna <vinschen at redhat.com>
Thank you, but "Corinna Vinschen", please.
Thanks,
Corinna
More information about the Intel-wired-lan
mailing list