[Intel-wired-lan] [PATCH net-next v3] igbvf: add PCI reset handler functions
Szlosek, Marek
marek.szlosek at intel.com
Wed Mar 8 14:42:27 UTC 2023
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Kamil Maziarz
> Sent: środa, 1 marca 2023 11:57
> To: intel-wired-lan at lists.osuosl.org
> Cc: Wesierski, DawidX <dawidx.wesierski at intel.com>; Kubiak, Michal
> <michal.kubiak at intel.com>; Maziarz, Kamil <kamil.maziarz at intel.com>
> Subject: [Intel-wired-lan] [PATCH net-next v3] igbvf: add PCI reset handler
> functions
>
> From: Dawid Wesierski <dawidx.wesierski at intel.com>
>
> There was a problem with resuming ping after conducting a PCI reset.
> This commit adds two functions, igbvf_io_prepare and igbvf_io_done, which,
> after being added to the pci_error_handlers struct, will prepare the drivers
> for a PCI reset and then bring the interface up and reset it after. This will
> prevent the driver from ending up in incorrect state. Test_and_set_bit is
> highly reliable in this context, so we are not including a timeout in this
> commit
>
> This introduces 900ms - 1100ms of overhead to this operation but it's in non-
> time-critical flow. And also alows the driver to continue functioning after the
> reset.
>
> Functionality documented in ethernet-controller-i350-datasheet 4.2.1.3
> https://www.intel.com/content/www/us/en/products/details/ethernet/giga
> bit-controllers/i350-controllers/docs.html
>
> Signed-off-by: Dawid Wesierski <dawidx.wesierski at intel.com>
> Signed-off-by: Kamil Maziarz <kamil.maziarz at intel.com>
> Reviewed-by: Michal Kubiak <michal.kubiak at intel.com>
> ---
> v2: added newlines
> ---
> v3: changed commit msg
> ---
> drivers/net/ethernet/intel/igbvf/netdev.c | 29 +++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
> b/drivers/net/ethernet/intel/igbvf/netdev.c
> index 72cb1b56e9f2..7ff2752dd763 100644
> --- a/drivers/net/ethernet/intel/igbvf/netdev.c
> +++ b/drivers/net/ethernet/intel/igbvf/netdev.c
Tested-by: Marek Szlosek <marek.szlosek at intel.com>
More information about the Intel-wired-lan
mailing list