[Intel-wired-lan] [PATCH RESEND net v1 1/2] iavf: fix inverted Rx hash condition leading to disabled hash

Romanowski, Rafal rafal.romanowski at intel.com
Tue Mar 14 15:19:30 UTC 2023


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: środa, 1 marca 2023 12:59
> To: Nguyen, Anthony L <anthony.l.nguyen at intel.com>
> Cc: Zaremba, Larysa <larysa.zaremba at intel.com>; netdev at vger.kernel.org;
> Brandeburg, Jesse <jesse.brandeburg at intel.com>; linux-
> kernel at vger.kernel.org; Eric Dumazet <edumazet at google.com>; Kubiak,
> Michal <michal.kubiak at intel.com>; intel-wired-lan at lists.osuosl.org; Jakub
> Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; David S.
> Miller <davem at davemloft.net>
> Subject: [Intel-wired-lan] [PATCH RESEND net v1 1/2] iavf: fix inverted Rx
> hash condition leading to disabled hash
> 
> Condition, which checks whether the netdev has hashing enabled is
> inverted. Basically, the tagged commit effectively disabled passing flow hash
> from descriptor to skb, unless user *disables* it via Ethtool.
> Commit a876c3ba59a6 ("i40e/i40evf: properly report Rx packet hash") fixed
> this problem, but only for i40e.
> Invert the condition now in iavf and unblock passing hash to skbs again.
> 
> Fixes: 857942fd1aa1 ("i40e: Fix Rx hash reported to the stack by our driver")
> Reviewed-by: Larysa Zaremba <larysa.zaremba at intel.com>
> Reviewed-by: Michal Kubiak <michal.kubiak at intel.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin at intel.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> index 18b6a702a1d6..e989feda133c 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c


Tested-by: Rafal Romanowski <rafal.romanowski at intel.com>





More information about the Intel-wired-lan mailing list