[Intel-wired-lan] [PATCH net-next v2] igb: refactor igb_ptp_adjfine_82580 to use diff_by_scaled_ppm

[Pucha, HimasekharX Reddy]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Keller, Jacob E
> Sent: Thursday, March 9, 2023 3:22 AM
> To: intel-wired-lan at osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH net-next v2] igb: refactor igb_ptp_adjfine_82580 to use diff_by_scaled_ppm
>
>
>
> On 3/8/2023 2:36 AM, Andrii Staikov wrote:
> Driver's .adjfine interface functions use adjust_by_scaled_ppm and 
> diff_by_scaled_ppm introduced in commit 1060707e3809
> ("ptp: introduce helpers to adjust by scaled parts per million") to 
> calculate the required adjustment in a concise manner, but not 
> igb_ptp_adjfine_82580.
> Fix it by introducing IGB_82580_BASE_PERIODand changing function logic 
> to use diff_by_scaled_ppm.
> 
> Fixes: 1060707e3809 ("ptp: introduce helpers to adjust by scaled parts 
> per million")
> Signed-off-by: Andrii Staikov <andrii.staikov at intel.com>
>
> Thanks for this. I missed this function when doing the refactor above.
> This change looks correct to me.
>
> I'm not sure this would qualify as a bug fix sent to net, but:
>
> Reviewed-by: Jacob Keller <jacob.e.keller at intel.com>
>
> ---
> v2: Changing target to net-queue and reflowing commit message to fit 
> 75 characters per line.
>
> The subject still says this targets net-next, but I think that's fine.
>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>  

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha at intel.com> (A Contingent worker at Intel)