[Intel-wired-lan] [PATCH net v3] e1000e: Disable TSO on i219-LM card to increase speed

[Kai-Heng Feng]

Hi Mateusz,

On Wed, Mar 15, 2023 at 8:44 PM Palczewski, Mateusz
<mateusz.palczewski at intel.com> wrote:
[snipped]
> > > Also the questions from the discussion of v2(?) was not answered, why
> > > the conditions in the if statement of the code added by commit
> > > f29801030ac6 where not true.
> > >
> > >      /* disable TSO for pcie and 10/100 speeds, to avoid
> > >       * some hardware issues
> > >       */
> > >      if (!(adapter->flags & FLAG_TSO_FORCE)) {
> >
> > Yea, my idea was to take FLAG_TSO_FORCE into consideration hence the adding the change to this if block.
> >
> > Maybe someone still wants to enable TSO despite of the downside?
>
> By disabling TSO during probe we are not shutting it down completly, if a user wants to use it anyway despite speed decrease it can be done manually with ethtool.

Maybe move the whole block of "FLAG_TSO_FORCE" to probe routine? So
the code is logically grouped.

Kai-Heng