[Intel-wired-lan] [PATCH net, v2] ice: fix wrong fallback logic for FDIR

[Romanowski, Rafal]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Simei Su
> Sent: środa, 22 marca 2023 03:24
> To: intel-wired-lan at lists.osuosl.org
> Cc: Su, Simei <simei.su at intel.com>
> Subject: [Intel-wired-lan] [PATCH net, v2] ice: fix wrong fallback logic for FDIR
> 
> When adding a FDIR filter, if ice_vc_fdir_set_irq_ctx returns failure, the
> inserted fdir entry will not be removed and if ice_vc_fdir_write_fltr returns
> failure, the fdir context info for irq handler will not be cleared which may lead
> to inconsistent or memory leak issue. This patch refines failure cases to
> resolve this issue.
> 
> Fixes: 1f7ea1cd6a37 ("ice: Enable FDIR Configure for AVF")
> Signed-off-by: Simei Su <simei.su at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> index 60c9da4aac1d..c03e4a7ae80b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c
> @@ -1812,7 +1812,7 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg)


Tested-by: Rafal Romanowski <rafal.romanowski at intel.com>