[Intel-wired-lan] [PATCH net-next v1] ice: refactor to remove not needed packing
Jesse Brandeburg
jesse.brandeburg at intel.com
Thu Mar 30 19:21:51 UTC 2023
On 3/30/2023 12:18 PM, Jesse Brandeburg wrote:
> After the changes to the structures to make them flex array safe,
> packing is no longer necessary.
>
> to reproduce:
> make EXTRA_CFLAGS=-Wpacked drivers/net/ethernet/intel/ice/ice.ko
>
> In file included from drivers/net/ethernet/intel/ice/ice_controlq.h:7,
> from drivers/net/ethernet/intel/ice/ice_type.h:14,
> from drivers/net/ethernet/intel/ice/ice.h:59:
> drivers/net/ethernet/intel/ice/ice_adminq_cmd.h:618:1: warning: packed attribute is unnecessary for ‘ice_aqc_sw_rules_elem_hdr’ [-Wpacked]
> 618 | } __packed __aligned(sizeof(__le16));
> | ^
> drivers/net/ethernet/intel/ice/ice_adminq_cmd.h:705:1: warning: packed attribute is unnecessary for ‘ice_sw_rule_lkup_rx_tx’ [-Wpacked]
> 705 | } __packed __aligned(sizeof(__le16));
> | ^
> drivers/net/ethernet/intel/ice/ice_adminq_cmd.h:767:1: warning: packed attribute is unnecessary for ‘ice_sw_rule_lg_act’ [-Wpacked]
> 767 | } __packed __aligned(sizeof(__le16));
> | ^
> drivers/net/ethernet/intel/ice/ice_adminq_cmd.h:779:1: warning: packed attribute is unnecessary for ‘ice_sw_rule_vsi_list’ [-Wpacked]
> 779 | } __packed __aligned(sizeof(__le16));
> | ^
>
> Fixes: 6e1ff618737a ("ice: fix access-beyond-end in the switch code")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
please ignore this one, I sent it to the wrong base tree (next instead
of net)
see v2...
More information about the Intel-wired-lan
mailing list