[Intel-wired-lan] [PATCH net-next 01/15] virtchnl: add virtchnl version 2 ops

[Shannon Nelson]

On 4/4/23 12:59 AM, Orr, Michael wrote:
> 
> This version is not yet the standard IDPF version. It is the current Intel driver.
> The mentions of “standard” and OASIS Zaretsky because this version is the
> Basis from which a standard driver WILL be developed at OASIS, which is relevant info to know.

Please clearly spell out this intent and any related expectations in the 
cover letter.

sln

> 
> --
> Michael Orr.            Cell: +1(408)636-3744
> Note: Dyslexic here. Even on speller-equipped iPad, typos Probable.
> 
>> On Apr 4, 2023, at 01:55, Shannon Nelson <shannon.nelson at amd.com> wrote:
>>
>> On 4/3/23 3:20 PM, Jakub Kicinski wrote:
>>> On Mon, 3 Apr 2023 15:01:55 -0700 Shannon Nelson wrote:
>>>>> diff --git a/drivers/net/ethernet/intel/idpf/virtchnl2.h b/drivers/net/ethernet/intel/idpf/virtchnl2.h
>>>>
>>>> If this is to be a standardized interface, why is this header buried in
>>>> the driver specific directory instead of something more accessible like
>>>> include/linux/idpf?
>>> The noise about this driver being "a standard" is quite confusing.
>>> Are you considering implementing any of it?
>>> I haven't heard of anyone who is yet, so I thought all this talk of
>>> a standard is pretty empty from the technical perspective :(
>>
>> Just that they seem to be pushing it to become a standard through OASIS,
>> as they infer by pointing to their OASIS docs in this patch, and I was under the (mistaken?) impression that this would be the One Driver for any device that implemented the HW/FW interface, kinda like virtio.  If that's true, then why would the driver live under the Intel directory?
>>
>> sln