[Intel-wired-lan] [PATCH net v2] i40e: fix accessing vsi->active_filters without holding lock

Pucha, HimasekharX Reddy himasekharx.reddy.pucha at intel.com
Tue Apr 4 11:25:54 UTC 2023


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Loktionov, Aleksandr
> Sent: Friday, March 24, 2023 10:47 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Loktionov, Aleksandr <aleksandr.loktionov at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v2] i40e: fix accessing vsi->active_filters without holding lock
>
> From: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
>
> Fix accessing vsi->active_filters without holding the mac_filter_hash_lock.
> Move vsi->active_filters = 0 inside critical section and move clear_bit(__I40E_VSI_OVERFLOW_PROMISC, vsi->state) after the critical section to ensure the new filters from other threads can be added only after filters cleaning in the critical section is finished.
>
> Fixes: 278e7d0b9d68 ("i40e: store MAC/VLAN filters in a hash with the MAC Address as key")
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha at intel.com> (A Contingent worker at Intel)


More information about the Intel-wired-lan mailing list