[Intel-wired-lan] [PATCH net-next v3 5/8] ice: remove redundant SRIOV code

[Romanowski, Rafal]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Simon Horman
> Sent: niedziela, 26 marca 2023 15:36
> To: Raczynski, Piotr <piotr.raczynski at intel.com>
> Cc: Swiatkowski, Michal <michal.swiatkowski at intel.com>;
> netdev at vger.kernel.org; Brandeburg, Jesse
> <jesse.brandeburg at intel.com>; intel-wired-lan at lists.osuosl.org; Saleem,
> Shiraz <shiraz.saleem at intel.com>
> Subject: Re: [Intel-wired-lan] [PATCH net-next v3 5/8] ice: remove
> redundant SRIOV code
> 
> On Thu, Mar 23, 2023 at 01:24:37PM +0100, Piotr Raczynski wrote:
> > Remove redundant code from ice_get_max_valid_res_idx that has no
> effect.
> > ice_pf::irq_tracker is initialized during driver probe, there is no
> > reason to check it again. Also it is not possible for
> > pf::sriov_base_vector to be lower than the tracker length, remove
> WARN_ON that will never happen.
> >
> > Get rid of ice_get_max_valid_res_idx helper function completely since
> > it can never return negative value.
> >
> > Reviewed-by: Jacob Keller <jacob.e.keller at intel.com>
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> > Signed-off-by: Piotr Raczynski <piotr.raczynski at intel.com>
> 
> Reviewed-by: Simon Horman <simon.horman at corigine.com>


Tested-by: Rafal Romanowski <rafal.romanowski at intel.com>