[Intel-wired-lan] [PATCH net-next v4 2/5] ice: remove redundant Rx field from rule info
Leon Romanovsky
leon at kernel.org
Sun Apr 9 10:33:49 UTC 2023
On Fri, Apr 07, 2023 at 06:52:16PM +0200, Michal Swiatkowski wrote:
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
>
> Setting direction flag doesn't mean that there is a match criteria for
> direction in rule. It is only a information for HW from where switch id
> should be collected (VSI or port). In current implementation of advance
> rule handling, without matching for direction meta data, we can always
> set one the same flag and everything will work the same.
>
> Ability to match on direction meta data will be added in follow up
> patches.
>
> Recipe 0, 3 and 9 loaded from package has direction match
> criteria, but they are handled in other function.
>
> Move ice_adv_rule_info fields to avoid holes.
>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski at intel.com>
> Reviewed-by: Simon Horman <simon.horman at corigine.com>
> ---
> drivers/net/ethernet/intel/ice/ice_eswitch.c | 1 -
> drivers/net/ethernet/intel/ice/ice_switch.c | 22 ++++++++++----------
> drivers/net/ethernet/intel/ice/ice_switch.h | 8 +++----
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 5 -----
> 4 files changed, 14 insertions(+), 22 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro at nvidia.com>
More information about the Intel-wired-lan
mailing list