[Intel-wired-lan] [PATCH net-next v4 2/5] ice: remove redundant Rx field from rule info

Buvaneswaran, Sujai sujai.buvaneswaran at intel.com
Mon Apr 24 06:40:55 UTC 2023


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Michal Swiatkowski
> Sent: Friday, April 7, 2023 10:22 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: pmenzel at molgen.mpg.de; netdev at vger.kernel.org; Simon Horman
> <simon.horman at corigine.com>
> Subject: [Intel-wired-lan] [PATCH net-next v4 2/5] ice: remove redundant Rx
> field from rule info
> 
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
> 
> Setting direction flag doesn't mean that there is a match criteria for direction
> in rule. It is only a information for HW from where switch id should be
> collected (VSI or port). In current implementation of advance rule handling,
> without matching for direction meta data, we can always set one the same
> flag and everything will work the same.
> 
> Ability to match on direction meta data will be added in follow up patches.
> 
> Recipe 0, 3 and 9 loaded from package has direction match criteria, but they
> are handled in other function.
> 
> Move ice_adv_rule_info fields to avoid holes.
> 
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski at intel.com>
> Reviewed-by: Simon Horman <simon.horman at corigine.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_eswitch.c |  1 -
> drivers/net/ethernet/intel/ice/ice_switch.c  | 22 ++++++++++----------
> drivers/net/ethernet/intel/ice/ice_switch.h  |  8 +++----
> drivers/net/ethernet/intel/ice/ice_tc_lib.c  |  5 -----
>  4 files changed, 14 insertions(+), 22 deletions(-)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran at intel.com>



More information about the Intel-wired-lan mailing list