[Intel-wired-lan] [PATCH net v2] ice: Fix ice VF reset during iavf initialization

Romanowski, Rafal rafal.romanowski at intel.com
Mon Apr 24 13:25:30 UTC 2023


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Kamil Maziarz
> Sent: wtorek, 18 kwietnia 2023 11:53
> To: intel-wired-lan at lists.osuosl.org
> Cc: Wesierski, DawidX <dawidx.wesierski at intel.com>; Maziarz, Kamil
> <kamil.maziarz at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v2] ice: Fix ice VF reset during iavf
> initialization
> 
> From: Dawid Wesierski <dawidx.wesierski at intel.com>
> 
> Fix the current implementation that causes ice_trigger_vf_reset() to start
> resetting the VF even when the VF is still resetting itself and initializing
> adminq. This leads to a series of -53 errors (failed to init adminq) from the
> IAVF.
> 
> Change the state of the vf_state field to be not active when the IAVF asks for
> a reset. To avoid issues caused by the VF being reset too early, make sure to
> wait until receiving the message on the message box to know the exact state
> of the IAVF driver.
> 
> Fixes: c54d209c78b8 ("ice: Wait for VF to be reset/ready before
> configuration")
> Signed-off-by: Dawid Wesierski <dawidx.wesierski at intel.com>
> Signed-off-by: Kamil Maziarz <kamil.maziarz at intel.com>
> Acked-by: Jacob Keller <Jacob.e.keller at intel.com>
> ---
> v2: changed "reseted" to "reset", changed fixes tag, removed space
> ---
>  drivers/net/ethernet/intel/ice/ice_sriov.c    |  8 ++++----
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 19 +++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  1 +
>  drivers/net/ethernet/intel/ice/ice_virtchnl.c |  1 +
>  4 files changed, 25 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c
> b/drivers/net/ethernet/intel/ice/ice_sriov.c
> index 0cc05e54a781..d4206db7d6d5 100644
> --- a/drivers/net/ethernet/intel/ice/ice_sriov.c
> +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c


Tested-by: Rafal Romanowski <rafal.romanowski at intel.com>





More information about the Intel-wired-lan mailing list