[Intel-wired-lan] [PATCH net-next 06/12] ice: Add guard rule when creating FDB in switchdev

[Alexander Lobakin]

From: Wojciech Drewek <wojciech.drewek at intel.com>
Date: Wed, 26 Apr 2023 11:50:56 +0200

> 
> 
>> -----Original Message-----
>> From: Drewek, Wojciech
>> Sent: wtorek, 25 kwietnia 2023 11:18
>> To: Lobakin, Aleksander <aleksander.lobakin at intel.com>

[...]

>>> 	guard_rule = ice_eswitch_...
>>> 	err = PTR_ERR(guard_rule);
>>> 	if (err) {
>>> 		...
>>>
>>
>> I like it, less ptr <-> macros
> 
> Actually it won't work, PTR_ERR would not convert pointer to 0 in case of success.

Ooops, PTR_ERR_OR_ZERO() then? I forgot there are several macros for
different cases =\

> 
>>
>>>> +		dev_err(dev, "Failed to create eswitch bridge %sgress guard rule, err: %d\n",
>>>> +			port_type == ICE_ESWITCH_BR_UPLINK_PORT ? "e" : "in",
>>>> +			err);
>>>
>>> You still can print it via "%pe" + @guard_rule instead of @err :p (same
>>> with @fwd_rule above)
[...]

Thanks,
Olek