[Intel-wired-lan] [PATCH net v1] ice: Schedule service task in IRQ thread_fn

Tony Nguyen anthony.l.nguyen at intel.com
Mon May 8 20:24:23 UTC 2023


On 5/4/2023 6:08 AM, Yochai Hagvi wrote:
> On some RT kernels, scheduling service task in interrupt context may
> result in a kernel panic.
Would be nice if you could provide an example

> This is happenning due to queue_work call.

s/happenning/happening

> Move ice_service_task_schedule to IRQ bottom half.
> 

Please provide Fixes: for net patches

> Signed-off-by: Karol Kolacinski <karol.kolacinski at intel.com>
> Signed-off-by: Yochai Hagvi <yochai.hagvi at intel.com>
> ---

...

> @@ -3172,16 +3168,12 @@ static irqreturn_t ice_misc_intr(int __always_unused irq, void *data)
>   		if (oicr & (PFINT_OICR_PCI_EXCEPTION_M |
>   			    PFINT_OICR_ECC_ERR_M)) {
>   			set_bit(ICE_PFR_REQ, pf->state);
> -			ice_service_task_schedule(pf);
>   		}

Single line now, not braces needed.

>   	}


More information about the Intel-wired-lan mailing list